icssc / AntAlmanac

A course exploration and scheduling tool for UCI Anteaters
https://antalmanac.com
MIT License
58 stars 72 forks source link

"News" is not new at all #472

Closed MinhxNguyen7 closed 1 year ago

MinhxNguyen7 commented 1 year ago

The News box seems to contain not very new information, with the most recent being from 11 months ago image I can remove it if we want to do that. Also, maybe we should just automatically not display "news" that are more than a certain age.

ap0nia commented 1 year ago

My alpha branch implements infinite scrolling news; it'll always show the ~5 latest news on top, and you can infinitely load more items as you scroll down.

https://github.com/icssc/AntAlmanac/blob/aponia-monorepo/apps/client/src/components/Header/News.tsx

However, this doesn't address the concern of filtering for recent dates. Any thoughts? @MinhxNguyen7

MinhxNguyen7 commented 1 year ago

@johnlorenzini is working to replace this with the patch notes modal I think. Having infinite scroll on patch notes could make sense.

ap0nia commented 1 year ago

This feature was inspired by the notification bell on YouTube; clicking on the bell opens a popup that can scroll infinitely (I don't have any notifications so it's empty).

image

I don't think it makes much sense to implement this for the patch notes modal mainly because modals shouldn't be the primary way of displaying lot of info. Also, the infinite scroll exists as a way to browse previous news if the user is interested in viewing them, but the patch notes modal is currently intended to be hidden unless the user has never seen the modal before, defeating the purpose of being able to view the news at any time

MinhxNguyen7 commented 1 year ago

I'm not that familiar with what the vision with the news/patch notes is. You'll just have to ask @johnlorenzini