icssc / AntAlmanac

A course exploration and scheduling tool for UCI Anteaters
https://antalmanac.com
MIT License
54 stars 64 forks source link

Export schedule to .ics doesn't include custom events #741

Closed EricPedley closed 7 months ago

EricPedley commented 11 months ago

Also, if your schedule consists only of custom events, the download button doesn't do anything. This is consistent with what happens when you have nothing on your schedule, which is probably also not good, as it should make a snackbar popping up saying it failed to download because your schedule is empty.

KevinWu098 commented 11 months ago

disintegrate

KevinWu098 commented 11 months ago

Okay so, this isn't actually a bug I think? It's a feature 🤭

Similar to how copy schedule doesn't actually copy custom events (which is not necessarily intended, but also not not intended), I think this was just how the code was originally written... (also reminds me to add custom events to copy schedule)

Can't hurt to add the feature though; I'm almost tempted to say good first task

JacE070 commented 10 months ago

Bruh I think my change does this. I thought the issue originally includes this part lol https://github.com/icssc/AntAlmanac/pull/742

KevinWu098 commented 7 months ago

Closed by #742