icssc / AntAlmanac

A course exploration and scheduling tool for UCI Anteaters
https://antalmanac.com
MIT License
54 stars 64 forks source link

Some waypoints don't show up in map #784

Closed MinhxNguyen7 closed 10 months ago

MinhxNguyen7 commented 10 months ago

The second waypoint is missing in this schedule. See schedule "map-error"

image
KevinWu098 commented 10 months ago
    const validBuildingCodes = [...uniqueBuildingCodes].filter(
        (buildingCode) => buildingCatalogue[locationIds[buildingCode]] != null
    );

This is the reason why (from Map.tsx) ^^

The changes in #779, although confirmed to still work for all of the locations in map search, didn't take into account that location_ids.ts are the apparent source of truth for which ID in the list is the one we use. There may be more discrepancies still, but this is likely the source of the issue here

KevinWu098 commented 10 months ago

Should we revert #779 in this instance? Or just push a patch for it?

MinhxNguyen7 commented 10 months ago

Fixed by #785