search

icssc / AntAlmanac

A course exploration and scheduling tool for UCI Anteaters
https://antalmanac.com
MIT License
54 stars 64 forks source link

feat: Update Settings Menu #810

Closed KevinWu098 closed 9 months ago

KevinWu098 commented 9 months ago

Summary

  1. Implemented a new settings menu using the Drawer component
  2. ButtonGroup replaces the previous implementation which used the RadioGroup component

Settings Menu Gif

Screenshot 2023-11-26 at 10 34 40 PM

Test Plan

  1. Mobile and Desktop Responsiveness
  2. The underlying functions haven't changed, but check that the buttons do work as intended

Issues

Closes #805

KevinWu098 commented 9 months ago

Looks awesome, I love it.

While you're at it, can you move the settings out to a Zustand store? We want to be removing, not adding things to AppStore.

Also, if you're in the mood, you could make the settings persist with localstorage.

Will do :), ✨ Zustand ✨.Also, I believe the settings are stored in localstorage already!

KevinWu098 commented 9 months ago

Actually no, PR isn't done yet 🫠; i forgot to add in indicators for which setting is selected 😭

KevinWu098 commented 9 months ago

I think it would also be worth considering moving the Schedule Conflict feature into the Settings Menu. Because of how apparent it makes itself, it feels like a feature users could choose to enable / disable; Thoughts?

To be implemented in another PR*