icssc / AntAlmanac

A course exploration and scheduling tool for UCI Anteaters
https://antalmanac.com
MIT License
54 stars 64 forks source link

feat: Create Snackbar When Copying Schedules #811

Closed KevinWu098 closed 9 months ago

KevinWu098 commented 9 months ago

Summary

  1. Open snackbar when copying (appending) schedules; happens on success and on failure

Snackbar opens on success

Test Plan

  1. Check that the snackbar opens appropriately on success and on failure

Issues

Closes #

KevinWu098 commented 9 months ago

I'm not sure if my type definition for the CallbackOptions is proper, so just lmk if there's a better way to do them @ap0nia

export interface CallbackOptions {
    onSuccess: (name?: string) => unknown;
    onError: (name?: string) => unknown;
}
ap0nia commented 9 months ago

I kinda wanna write tests for it, but I don't wanna write tests for it lol.

What do you wanna do Kevin? If you don't wanna test, then I'll just approve and merge 🤓

KevinWu098 commented 9 months ago

I kinda wanna write tests for it, but I don't wanna write tests for it lol.

What do you wanna do Kevin? If you don't wanna test, then I'll just approve and merge 🤓

If it breaks it breaks, and somebody gets extra contribution history 😋

KevinWu098 commented 9 months ago

TLDR let's merge 😅, do you need me to do a noop?

ap0nia commented 9 months ago

Yeah I think I need an extra commit from someone aside from me lol. Unless you're able to merge it yourself.

ap0nia commented 9 months ago

image lol it's not working