Previously, handleClosePopover() would never be triggered as close always evaluated to false, even when no param was passed into updateEventsInCalendar. In the refactor, I omitted a check, since I expected nothing would change... haha
To whomever is reviewing this PR, if you can explain to me why that is the case when close = true in the snippet, please let me know.
Test Plan
Color Picker shouldn't close on the Calendar Root when clicked.
Popovers should close when events are changed and when index changes.
Summary
Previously,
handleClosePopover()
would never be triggered asclose
always evaluated to false, even when no param was passed intoupdateEventsInCalendar
. In the refactor, I omitted a check, since I expected nothing would change... hahaTo whomever is reviewing this PR, if you can explain to me why that is the case when
close = true
in the snippet, please let me know.Test Plan
Issues
Bug Report: https://discord.com/channels/772739905981644850/780316580819107860/1192200165948395561