Because I'm a pedant, I'll say that the the better implementation of appTheme == "dark" would be appTheme.isDark() so that "dark" and "light" aren't magic values. Intellisense tells you, but you ideally shouldn't need Intellisence. I say it for the sake of future code.
Because I'm a pedant, I'll say that the the better implementation of
appTheme == "dark"would beappTheme.isDark()so that "dark" and "light" aren't magic values. Intellisense tells you, but you ideally shouldn't need Intellisence. I say it for the sake of future code.Originally posted by @MinhxNguyen7 in https://github.com/icssc/AntAlmanac/pull/847#pullrequestreview-1795945578