icssc / AntAlmanac

A course exploration and scheduling tool for UCI Anteaters
https://antalmanac.com
MIT License
54 stars 64 forks source link

GPA Column is Broken for ICS classes #860

Closed MinhxNguyen7 closed 6 months ago

MinhxNguyen7 commented 7 months ago

@KevinWu098 conjectures that it's an API change that broke it about a month ago.

@ecxyzzy

MinhxNguyen7 commented 7 months ago

@ecxyzzy It's only ICS classes. Maybe there's something with escaping the ampersand, but GEN&SEX works just fine.

JacE070 commented 7 months ago

By looking up Peterportal GraphQL API, I found this: image There are two values for ICS which point to the same department.

Things go normal if you put "I&CSCI" as department instead of "I&C SCI".

We can just put a patch rn, but only expediently.

Do we have certain reason for having this? @ecxyzzy

JacE070 commented 7 months ago

By looking up Peterportal GraphQL API, I found this: image There are two values for ICS which point to the same department.

We can just put a patch rn, but only expediently.

Do we have certain reason for having this? @ecxyzzy

You can get this if you pass the query string and POST to https://api-next.peterportal.org/v1/graphql query { depts { deptLabel, deptValue } }

Peterportal playground: https://api.peterportal.org/graphql-playground

ecxyzzy commented 6 months ago

Should be resolved now, sorry about the delay.

It looks like something trimmed the spaces of all department codes during the migration to PostgreSQL.

KevinWu098 commented 6 months ago

Banger 🙏