Show all past enrollment graphs

icssc / AntAlmanac

A course exploration and scheduling tool for UCI Anteaters

https://antalmanac.com

MIT License

54 stars 64 forks source link

Show all past enrollment graphs #867

Closed Douglas-Hong closed 6 months ago

Douglas-Hong commented 6 months ago

Summary

The user can navigate back and forth between all the past enrollment graphs for a specific course

TODO

[x] Show all past enrollment graphs
[x] Improve the design for mobile

Test Plan

Verify this works for classes in the most recent quarter (e.g. CS 143A).
Verify this works for classes that haven't been offered very recently (e.g. CS 122D from Spring 2023).
Make sure the modal looks good on mobile and light/dark mode.

Issues

Closes #830

Future Follow-up

I tried to add an instructor filter, but Material UI has problems when we add a select menu to a popper. We can tackle this later. Or, we can just not implement it because it would clutter the popper, and the user can go to ZotTracker for more advanced searching.

github-actions[bot] commented 6 months ago

Deployed staging instance to https://staging-867.antalmanac.com

KevinWu098 commented 6 months ago

Great feature, but I'm very confused about the arrow placement?

Why are past enrollments navigated to with the right arrow and vice versa? It seems very unintuitive, and after some user testing, 5/5 users immediately went towards the lefthand side when asked to show me a prior quarter's courses.

@Douglas-Hong Can we swap it around?

Douglas-Hong commented 6 months ago

@KevinWu098 that's a good point. I also thought about this a lot when I was implementing the feature. Here is my thought process: first, I want to show the most recent quarter's enrollment data when the popup is opened since the most recent quarters are probably more relevant. Then, I thought it would be awkward to have the right arrow instead of the left arrow be disabled when the popup first appears because normally that implies we have reached the end of a list. Therefore, instead of having the list be from oldest quarter to most recent quarter, I thought it would be better to go from most recent quarter to oldest quarter. I'm not sure if that makes sense, lmk if you need any clarification.

However, based on the user testing, I think it's a good idea to swap the arrows. @EricPedley @ap0nia do you guys have any opinions about this?

KevinWu098 commented 6 months ago

@KevinWu098 that's a good point. I also thought about this a lot when I was implementing the feature. Here is my thought process: first, I want to show the most recent quarter's enrollment data since the most recent quarters are probably more relevant. Then, I thought it would be awkward to have the right arrow instead of the left arrow be disabled when the popup first appears because normally that implies we have reached the end of a list. Therefore, instead of having the list be from oldest quarter to most recent quarter, I thought it would be better to go from most recent quarter to oldest quarter. I'm not sure if that makes sense, lmk if you need any clarification.

However, based on the user testing, I think it's a good idea to swap the arrows. @EricPedley @ap0nia do you guys have any opinions about this?

Your reasoning makes sense, but I think we have to defer to the "default user behavior" of "older being lefter"

MinhxNguyen7 commented 6 months ago

I agree that older should be left.