fix: show recruitment banner again

icssc / AntAlmanac

A course exploration and scheduling tool for UCI Anteaters

https://antalmanac.com

MIT License

55 stars 62 forks source link

fix: show recruitment banner again #918

Closed KevinWu098 closed 4 months ago

KevinWu098 commented 4 months ago

Summary

The change to pass search queries as lowercase in #755 resulted in the Recruitment Banner never showing up, as the banner checked for uppercase queries, which are now lowercase.
Use .toUpperCase() on the value we grab from RightPaneStore

Test Plan

Go into Chrome Dev Tools and the application tab to clear your recruitmentDismissalTime. Then search for COMPSCI and see if it pops up.

KevinWu098 commented 4 months ago

It overlaps with the restart tutorial button :(

Any ideas for how to fix this? My first thought would to be moving the recruitment banner up a little bit with some css.

Could always move the tutorial up a few pixels 🏃‍♂️

KevinWu098 commented 4 months ago

It overlaps with the restart tutorial button :( Any ideas for how to fix this? My first thought would to be moving the recruitment banner up a little bit with some css.

Above:

Left:

It looks kinda wonky both ways, but I do prefer the left version. Any thoughts? @EricPedley

EricPedley commented 4 months ago

on the left looks good