feat: one tab mobile layer

icssc / AntAlmanac

A course exploration and scheduling tool for UCI Anteaters

https://antalmanac.com

MIT License

56 stars 70 forks source link

feat: one tab mobile layer #921

Closed KevinWu098 closed 5 months ago

KevinWu098 commented 7 months ago

Summary

Simplify our tab layout by removing the Calendar / Classes split in favor of Calendar / Search / Added / Map

To-do:

[x] Refactor to share code, reduce duplication
[x] Consider using icons (?), if screen width allows

Test Plan

UI testing

Issues

Closes #795

KevinWu098 commented 6 months ago

Reminder: update the tutorial so that it hooks onto something other than the desktop tabs

MinhxNguyen7 commented 5 months ago

@KevinWu098 How this looking? Also, the tutorial shouldn't show on mobile, so I'm not sure what you're referring to.

KevinWu098 commented 5 months ago

@KevinWu098 How this looking? Also, the tutorial shouldn't show on mobile, so I'm not sure what you're referring to.

I'll start back up on this PR this week; the comment above is referencing how the Tutorial is positioned to the RightPane, which the current implementation on this branch is reusing for mobile (and thus causing it to show up on mobile).

KevinWu098 commented 5 months ago

Very nice. Looks great. I do think that the bar should be at the bottom, but it's up to you if you want it to be.

I only have the concern about the listener. Also, while you're at it, can you resolve the merge conflict?

Issues are resolved.

I also agree that the button should be on the bottom, but that change carries a host of styling fixes and adjustments and I'd rather do those in a follow-up PR. We can discuss @ sprint