search

icssc / AntAlmanac

A course exploration and scheduling tool for UCI Anteaters
https://antalmanac.com
MIT License
55 stars 62 forks source link

Display "No Courses Added Yet" when list of added classes is empty #924

Closed ollykel closed 4 months ago

ollykel commented 4 months ago

Summary

Adds a "No Courses Added Yet!" notification in the right pane for Added courses when the list of added classes is empty.

Screenshot from 2024-02-26 12-06-45

Test Plan

Start from an empty schedule, add classes, then remove classes until the schedule is empty again. "No Courses Added!" should appear under the schedule name if and only if the list of added classes is empty.

Issues

Closes #922

Douglas-Hong commented 4 months ago

Thanks for tackling this issue! I think it would be a good idea to add some more styling, such as centering the text and adding some padding around it. @KevinWu098 do you have any opinions about this?

ollykel commented 4 months ago

Thank you for the feedback!

This is what is looks like with align="center" and padding="1.5px". Does it look alright? Also, is there a preferable way to add styling to elements?

Screenshot from 2024-02-26 16-39-44

KevinWu098 commented 4 months ago

Thank you for the feedback!

This is what is looks like with align="center" and padding="1.5px". Does it look alright? Also, is there a preferable way to add styling to elements?

Screenshot from 2024-02-26 16-39-44

Looks much better! Could you wrap the text with a background that would span the entire space? The text currently looks a tad "orphaned", for lack of a better term.

And in regards to styling, we usually write our styles inline, although we don't necessarily strictly enforce how styling should be done.

ollykel commented 4 months ago

Any preferences on background color?

Grey looks like this in dark mode and light mode:

Screenshot from 2024-02-27 10-32-08

Screenshot from 2024-02-27 10-32-21

Also changed the padding to 16px.

ollykel commented 4 months ago

Just committed some tweaks @KevinWu098, should look like the screenshots I posted above.

ollykel commented 4 months ago

No worries, thank you for the feedback.

I implemented the changes you requested, hopefully we should be good soon!

ollykel commented 4 months ago

LGTM! Thanks for working on this 🚀

Please squash and merge when you get a chance 💪

Thank you!

I don't have the right to merge, how should we move forward?

KevinWu098 commented 4 months ago

LGTM! Thanks for working on this 🚀 Please squash and merge when you get a chance 💪

Thank you!

I don't have the right to merge, how should we move forward?

Whoops, forgot about that. I'll merge it in 🫡