search

icssc / AntAlmanac

A course exploration and scheduling tool for UCI Anteaters
https://antalmanac.com
MIT License
55 stars 62 forks source link

Make area around top bar of mobile devices the same color as app bar (PWA) #935

Closed pinapelz closed 4 months ago

pinapelz commented 4 months ago

Summary

This PR builds off of #834 . The issue is that you need to explicitly tell iOS that your website is PWA capable and that you want the status bar to match the theme color in your meta tags.

Assuming you guys also want something similar on Android, you'll need to specify what color as a theme-color meta tag.

I've applied the previously proposed colors to the manifest files and made the necessary changes to the meta tags.

Deployment Note

The PWA currently does not work off of the dev server with port forwarding, so we need to figure that out or find another way to test it.

Before and After

Before After

Test Plan

Run locally and test visually

Issues

Closes #840

MinhxNguyen7 commented 4 months ago

How did you test this locally as a PWA?

The server seems to get completely borked when I try to access it as a PWA. I'm running Chrome on Android. @ap0nia any ideas why?

image
pinapelz commented 4 months ago

Are you running the dev server and forwarding the port? I tried that and ran into an issue for that where the PWA was just a white screen (even when I just cloned directly from the main repo)

I ended up just deploying it to Cloudflare pages via pnpm run build and that seemed to allow me to use the PWA. I have no idea why directly using the dev server doesn't work though.