search

icssc / AntAlmanac

A course exploration and scheduling tool for UCI Anteaters
https://antalmanac.com
MIT License
55 stars 62 forks source link

Make Scrollbar a Uniform Thinness for Right Pane #958

Closed adcockdalton closed 2 months ago

adcockdalton commented 2 months ago

Summary

This ended up being a really simple fix. To avoid creating unnecessary instances of GlobalStyles, I moved the one from CourseRenderPane.tsx into RightPaneRoot.tsx. Now all scrollbars on the right have unified thinness, which is the intended functionality, and are properly affected by one line rather than duplicate lines.

Test Plan

Test the styling Search CompSci Add a bunch of random classes Resize the window to show horizontal scrollbars Confirm on Search and Added that they as well as their vertical counterparts are all thin

Test the lag Scroll all the way down on a search or CompSci then use the back arrow and confirm no lag was reintroduced

Issues

Closes #938 without breaking #902 , thereby expanding #738

adcockdalton commented 2 months ago

Looking at this PR I'm realizing there might be some version control wonkiness--this was supposed to be a 2 file change and this PR is showing 11. Looking into it