This ended up being a really simple fix. To avoid creating unnecessary instances of GlobalStyles, I moved the one from CourseRenderPane.tsx into RightPaneRoot.tsx. Now all scrollbars on the right have unified thinness, which is the intended functionality, and are properly affected by one line rather than duplicate lines.
Changing the imports also has applied Prettier to the ordering of the imports for those two files. This seems to be nothing but a largely inconsequential improvement.
Edit: Apologies for the faulty PR prior to this. I have now fixed my version control and the ESLint issue I was having locally.
Test Plan
Test the styling
Search CompSci
Add a bunch of random classes
Resize the window to show horizontal scrollbars
Confirm on Search and Added that they as well as their vertical counterparts are all thin
Test the lag
Scroll all the way down on a search or CompSci then use the back arrow and confirm no lag was reintroduced
Issues
Closes #938 without breaking #902 , thereby expanding #738
Summary
This ended up being a really simple fix. To avoid creating unnecessary instances of GlobalStyles, I moved the one from CourseRenderPane.tsx into RightPaneRoot.tsx. Now all scrollbars on the right have unified thinness, which is the intended functionality, and are properly affected by one line rather than duplicate lines.
Changing the imports also has applied Prettier to the ordering of the imports for those two files. This seems to be nothing but a largely inconsequential improvement.
Edit: Apologies for the faulty PR prior to this. I have now fixed my version control and the ESLint issue I was having locally.
Test Plan
Test the styling Search CompSci Add a bunch of random classes Resize the window to show horizontal scrollbars Confirm on Search and Added that they as well as their vertical counterparts are all thin
Test the lag Scroll all the way down on a search or CompSci then use the back arrow and confirm no lag was reintroduced
Issues
Closes #938 without breaking #902 , thereby expanding #738