search

icssc / AntAlmanac

A course exploration and scheduling tool for UCI Anteaters
https://antalmanac.com
MIT License
56 stars 70 forks source link

Move Mobile Tabs to Bottom #976

Open KevinWu098 opened 5 months ago

KevinWu098 commented 5 months ago

I do think that the bar should be at the bottom

Screenshot 2024-05-04 at 12 23 30 PM

Originally posted by @MinhxNguyen7 in https://github.com/icssc/AntAlmanac/pull/921#pullrequestreview-2026748537

vinnyho commented 1 week ago

I will be trying to take this issue.

KevinWu098 commented 1 week ago

I will be trying to take this issue.

I believe this one is being worked on in #1001 !

MinhxNguyen7 commented 1 week ago

I will be trying to take this issue.

I believe this one is being worked on in #1001 !

I wouldn't hold my breath, since @ap0nia has graduated. @vinnyho feel free to take the relevant parts of his code to complete this PR.

KevinWu098 commented 1 week ago

I will be trying to take this issue.

I believe this one is being worked on in #1001 !

I wouldn't hold my breath, since @ap0nia has graduated. @vinnyho feel free to take the relevant parts of his code to complete this PR.

IIRC it's pretty damn close, as far as I can recall

@ap0nia can you confirm? would prefer not to send @vinnyho on the same path if we're close to completion!

ap0nia commented 1 week ago

I believe it should almost be done actually. I addressed the feedback that Kevin left on his review, and I was blocked on nitpicks like the name of components.

I can finish writing up the PR summary and QA testing with Kevin if that's alright.

vinnyho commented 1 week ago

Thank you, I will find another issue to try and fix. Good luck!