Error message needed when parent module is not correct

[GoogleCodeExporter]

If you set the wrong class for the parent module with the setParentModule 
method, a class cast exception occurs.

Instead Mvp4g should display an error message.

Original issue reported on code.google.com by plcoir...@gmail.com on 1 May 2010 at 9:51

[GoogleCodeExporter]

Attached is a patch that eliminates this problem by adding a setParentModule 
method to 
the Mvp4gModule interface. The parameter is a Mvp4gModule which is casted back 
to the 
proper type in child module method definition. Rather than using the parameter 
to 
determine the parent module type, it is saved into ChildModuleElement when they 
are 
loaded.

Original comment by HebnerN@gmail.com on 19 May 2010 at 7:39

[GoogleCodeExporter]

Thanks for the patch.

I have a question about your correction. For a child module, in 
Mvp4gConfiguration.java, findParentModule will always return null since a child 
module won't have an annotation @ChildModule with its class. Then you won't 
have 
access to parent module & parent event bus classes and won't be able to do the 
right 
cast. Am I missing something?

Original comment by plcoir...@gmail.com on 20 May 2010 at 2:50

[GoogleCodeExporter]

Indeed you are correct. I guess it was a bit too late to be coding... Anyway I 
have 
attached a patch that should be correct. This patch finds the parent type by 
searching 
through the annotation scan results for a class annotated with @ChildModules 
containing 
the module in question.

Original comment by HebnerN@gmail.com on 20 May 2010 at 4:02

Attachments:

• setParentModule.patch

[GoogleCodeExporter]

Included in the last snapshot

Original comment by plcoir...@gmail.com on 8 Jun 2010 at 10:19

• Changed state: Fixed