search

ictvmt / mvp4g

Automatically exported from code.google.com/p/mvp4g
0 stars 0 forks source link

Eventbus dispatch should use event's history name, not its event type. #60

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
This way, this would be possible and refractoring would be easier:
@Event(name=Constants.PAGE1)
void goToPage1();

eventBus.dispatch(Constants.PAGE1);

The attribute 'historyName' should be renamed 'name' since it would be use for 
more than just history.

By default, the name of an event would be the method's name.

Original issue reported on code.google.com by plcoir...@gmail.com on 7 Jan 2011 at 12:47

GoogleCodeExporter commented 8 years ago

Original comment by plcoir...@gmail.com on 7 Jan 2011 at 12:49

GoogleCodeExporter commented 8 years ago 
This will also impact history and filter.

Instead of event's type, event's name will also be used for filter (ie 
filterEvent method of the EventFilter object will receive the event's name 
instead of the event's type) and history converter (ie convertFromToken method 
of the HistoryConverter object will receive the event's name instead of the 
event's type).

Original comment by plcoir...@gmail.com on 20 Jan 2011 at 9:55

GoogleCodeExporter commented 8 years ago 
Included in the last snapshot

Original comment by plcoir...@gmail.com on 8 Feb 2011 at 1:37