icub-tech-iit / cad-libraries

In this repository we store the CAD libraries and the PTC Creo configuration files.
16 stars 9 forks source link

Editing [SLAMTEC_RPLIDAR-A2M4-R1]-[correcting mass] #65

Closed Mick3Lozzo closed 2 years ago

Mick3Lozzo commented 2 years ago
Description Field
Category [ECAD-MCAD]
Alias Creo SLAMTEC_RPLIDAR-A2M4-R1
IIT-Code 11404
Applicant Michele Gesino, @Mick3Lozzo
Supervisor Marco Maggiali, @maggia80
Maintainer Marcello Savoldi, @marcellosavoldi
Coworkers @icub-tech-iit/silo-mech

Description and motivation of the changing request:

Correcting the mass value, it should be 199 g.

Checklist:

Mick3Lozzo commented 2 years ago

image

Done.

Mick3Lozzo commented 2 years ago

Note: 199 g is a value obtained by weighting a 15507 -SLAMTEC_RPLIDAR-A3M1 model, I expect that there is no significant difference.

fiorisi commented 2 years ago

@Mick3Lozzo can you check the alias? As in https://github.com/icub-tech-iit/cad-libraries/issues/64#issuecomment-931407338, please check if it is compliant with the guidelines. In particular, is RPLIDAR part of the producer code?

fiorisi commented 2 years ago

Gentle reminder for @Mick3Lozzo.

Mick3Lozzo commented 2 years ago

@fiorisi on the website, RPLIDAR is used only with some components, I would consider it as part of the component's name.

fiorisi commented 2 years ago

In the datasheet of this component there is written A3M1. I think that RPLIDAR is the series. If you already used the part in many assemblies then we we can avoid the renaming.

image

Mick3Lozzo commented 2 years ago

@fiiorisi  already used It only in the ergoCub head, but there are other RPLIDAR models in the various R1 versions.

.... and they have RPLIDAR in the filename.

fiorisi commented 2 years ago

@fiiorisi already used It only in the ergoCub head, but there are other RPLIDAR models in the various R1 versions.

This is work done before the new guidelines and we do not modify it.

Mick3Lozzo commented 2 years ago

@fiorisi errata corrige: this is the OLD component present in R1 assemblies, added before the new guidelines.

The new RPLIDAR used in ergoCub head is the SLAMTEC_RPLIDAR_A3M1, which has been renamed in SLAMTEC_A3M1.