icub-tech-iit / ergocub-software

Main collector of ergoCub specific SW
https://icub-tech-iit.github.io/ergocub-software/
BSD 3-Clause "New" or "Revised" License
13 stars 18 forks source link

Install ergoCubEmotions application even with COMPILE_ergoCubEmotions off #196

Closed martinaxgloria closed 9 months ago

martinaxgloria commented 9 months ago

As per title, I created this PR to refactor the ergoCubEmotions module to have the ergoCubEmotions xml application for the yarpmanager on ergocub-laptop. In this way, when robotology-superbuild is installed:

I tried this changes on my laptop. The first time, I installed ergocub-software with the flag OFF, I opened the yarpmanager and I tried to launch the module from the configuration file (which is installed now):

Screenshot from 2023-11-30 17-10-54

Since no images and videos are installed, nothing is shown.

Then I rebuilt the repo with the flag ON, I repeated the passages listed above and this time I was able to see the expressions:

Screenshot from 2023-11-30 17-03-12

I'll take this PR in draft until these changes are tested on the robot.

martinaxgloria commented 9 months ago

Since ergoCub was not available, I tested the changes on the ergoCub setup on bench with the Orin NX and they worked smoothly: with this PR the module could be launched via the yarpmanager launched from the laptop, as the other yarpmanager applications

cc @Nicogene @pattacini

martinaxgloria commented 9 months ago

So we go for the solution proposed by @Nicogene? I could modify the README.md in accordance to this change

cc @traversaro

martinaxgloria commented 9 months ago

Hi @traversaro @Nicogene. Here https://github.com/icub-tech-iit/ergocub-software/pull/196/commits/8340017acaa56dd1eaa3941fc57ccd4dd1a7037e I applied the required changes and I also modified every CMakeLists copyright (like this). I hope that now it's ok