search

icub-tech-iit / ergocub-software

Main collector of ergoCub specific SW
https://icub-tech-iit.github.io/ergocub-software/
BSD 3-Clause "New" or "Revised" License
13 stars 18 forks source link

ergoCubV1_1: remove ft sensors of the arms #206

Closed Nicogene closed 8 months ago

Nicogene commented 8 months ago

It fixes #200

As side effect this PR removes also the nws for ergocub 1.0, the optimal solution would be to have two different xml files (e.g. ergocub1_0.xml. ergocub1_1.xml.

But since this a temporary workaround that will be hopefully soon reverted we could avoid to add yet another xml file to be maintained.

What do you think about @traversaro @GiulioRomualdi @pattacini ?

traversaro commented 8 months ago

What do you think about @traversaro @GiulioRomualdi @pattacini ?

Ok for me, if it is ok for @GiulioRomualdi @S-Dafarra @mebbaid

S-Dafarra commented 8 months ago

What do you think about @traversaro @GiulioRomualdi @pattacini ?

Ok for me, if it is ok for @GiulioRomualdi @S-Dafarra @mebbaid

No problem for me

Nicogene commented 8 months ago

I think we can merge it as it is, the only think is that on master branch landed this PR:

That requires to update gyp to the latest master.

If it is ok @GiulioRomualdi and @S-Dafarra I merge it otherwise if it is easier to use this branch please let me know

Nicogene commented 8 months ago

I rebased on latest master and I am going to merge it since I think I will soon revert it.