icub-tech-iit / ergocub-software

Main collector of ergoCub specific SW
https://icub-tech-iit.github.io/ergocub-software/
BSD 3-Clause "New" or "Revised" License
13 stars 18 forks source link

couplingXCubHandMk5: handle the param parsing with the YARP param parser generator #231

Open Nicogene opened 6 months ago

Nicogene commented 6 months ago

This PR introduces the usage of the new YARP param parsing generator, moreover using this new tool allows to align this device to the good practice of avoiding using the findGroup clause for parsing the lists, see:

Unfortunately some parameters are "shared" with the gazebo controlboards so using () for this device breaks the parsing of the gazebo controlboards, so I would put thi on hold until we do not make the change also on gyp side (cc @traversaro)

Moreover maybe it is better that YARP 3.10 has been released

traversaro commented 6 months ago

Moreover maybe it is better that YARP 3.10 has been released

Yes, that would be great. It would be problematic for people working on ergocub+gz-sim integration (@xela-95) if we could not release ergocub models until YARP 3.10 is released.

Nicogene commented 6 months ago

I have also ported all the ini in order to use the parenthesis, with this patch:

It works fine, @traversaro probably it would be convenient to have another gyp tag