icub-tech-iit / ergocub-software

Main collector of ergoCub specific SW
https://icub-tech-iit.github.io/ergocub-software/
BSD 3-Clause "New" or "Revised" License
13 stars 18 forks source link

[ergoCubSN00*/ergoCubGazeboV1*] Add alljoints-inertials to be aligned with real ergoCub #232

Closed martinaxgloria closed 5 months ago

martinaxgloria commented 5 months ago

This is the twin of https://github.com/robotology/icub-models-generator/pull/264. In this PR were added:

For the time being, I would keep this PR in draft since I want to see if the pose I added as XMLBlobs are correct.

cc @Nicogene @pattacini @traversaro

Nicogene commented 5 months ago

Awaiting this:

Before proceeding

martinaxgloria commented 5 months ago

Hi @Nicogene, I rebased this PR after solving the conflicts and now I put it ready for review.

martinaxgloria commented 5 months ago

Hi @Nicogene, thanks for generating the urdfs. I tried to launch the YRI with those models but I retrieved an error. In particular, there was a typo in a sensor name in alljoints-inertials_remapper. I fixed it here https://github.com/icub-tech-iit/ergocub-software/pull/232/commits/50fe75c72b730d422d16a409684d3a2eaa853f51.

traversaro commented 5 months ago

Am I missing something or the added .xml files were not added in the yarprobotinterface .xml file?

martinaxgloria commented 5 months ago

Am I missing something or the added .xml files were not added in the yarprobotinterface .xml file?

I didn't add them since in the real robots they were not added to the yri launch file

traversaro commented 5 months ago

Am I missing something or the added .xml files were not added in the yarprobotinterface .xml file?

I didn't add them since in the real robots they were not added to the yri launch file

I am probably missing something, but then how are the users supposed to use them if they are not launched with the yarprobotinterface (in both the simulated and the real robot case)?

traversaro commented 5 months ago

Sorry, I just noticed that you wrote ths in the original description, I missed this.