icub-tech-iit / ipts

iCub Tech PROTO Test Suite
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

Verify status of motor testing suite: test hall sensors #20

Closed Fabrizio69 closed 1 year ago

Fabrizio69 commented 1 year ago

Task Description

In reference to the previous issue the BLDC motor codes (7117,7116) are supported in ipts from this release:

but there is a problem: as indicated in the description of each code, these are motors without hall sensor

image image

while in the test report we can see :

image

Definition of Done

Verification done and issue solved

pattacini commented 1 year ago

Hi @Nicogene

We need to plan for it.

cc @davidetome

davidetome commented 1 year ago

I simply need to remove the test from the XML configuration file.

For the next codes to be added, I suggest opening an issue in https://github.com/icub-tech-iit/ipts describing :

cc @Nicogene @pattacini @Fabrizio69

pattacini commented 1 year ago

I simply need to remove the test from the XML configuration file.

See #21 for this.

Fabrizio69 commented 1 year ago

I simply need to remove the test from the XML configuration file.

For the next codes to be added, I suggest opening an issue in https://github.com/icub-tech-iit/ipts describing :

* Code / Description

* List of tests

* Images / Instructions needed for the tests

cc @Nicogene @pattacini @Fabrizio69

Thanks a lot @davidetome , remember that the motors are cod.7117 and cod.7116 (without hall sensors, from WinGST description)

Fabrizio69 commented 1 year ago

Head sprinkled with ashes 🙏

... sorry @davidetome , but ergoCub has another MOOG motor (@GiacomoVassallo13 is testing now):

image

It's not an urgent issue.

cc: @Nicogene @pattacini

davidetome commented 1 year ago

Ciao @Fabrizio69 ,

the motor is already present (See the tested code in the repo main page below) , the problem as already said is that you're using a very old rev of IPTS as the report above says...

Anyway let me produce the new release w/ the bug fix of the motor 7117 (I will do it this afernoon) and please install the latest release!

cc: @Nicogene @pattacini @GiacomoVassallo13

Fabrizio69 commented 1 year ago

... grazie @davidetome !!!

davidetome commented 1 year ago

📢 The new release of IPTS is available :

Please remove any old installations, and install it.

cc @Nicogene @pattacini @Fabrizio69 @GiacomoVassallo13