search

icub-tech-iit / urdf-modifiers

BSD 3-Clause "New" or "Revised" License
15 stars 4 forks source link

Fix Python package name in one-line install command #13

Closed traversaro closed 2 years ago

traversaro commented 2 years ago

The name of the repo is urdf-modifiers, but the Python package name is urdfModifiers. Before this modification, running the command resulted in this warning printed:

  WARNING: Generating metadata for package urdf-modifiers produced metadata for project name urdfmodifiers. Fix your #egg=urdf-modifiers fragments.
AlexAntn commented 2 years ago

Thanks for the fix @traversaro !

One question, would you include this fix in the tagged version we are going to create (in order not to break current implementations)? I think yes, but just confirming

GrmanRodriguez commented 2 years ago

Also, is this PR the fix for #14?

traversaro commented 2 years ago

Thanks for the fix @traversaro !

One question, would you include this fix in the tagged version we are going to create (in order not to break current implementations)? I think yes, but just confirming

Feel free to do so, in any case I do not think it is makes a bit difference.

traversaro commented 2 years ago

Also, is this PR the fix for #14?

No, unfortunatly https://github.com/icub-tech-iit/urdf-modifiers/issues/14 is still present even after this fix.