icub-tech-iit / urdf-modifiers

BSD 3-Clause "New" or "Revised" License
15 stars 4 forks source link

added pypi-ci #36

Closed CarlottaSartore closed 1 year ago

CarlottaSartore commented 1 year ago

This should address #35

Now on releases, urdf-modifier should be release on pypi

CarlottaSartore commented 1 year ago

C.C. @Nicogene @traversaro @mfussi66

traversaro commented 1 year ago

I guess we need to add a token secret here. I asked back in time to PyPI to get an organization, but I need to check what happen to that request. In the meanwhile I guess we need to add a personal token. @Nicogene @mfussi66 if you want I can handle that, let me know if that is ok.

Nicogene commented 1 year ago

I guess we need to add a personal token. @Nicogene @mfussi66 if you want I can handle that, let me know if that is ok.

Yes sure!

mfussi66 commented 1 year ago

I guess we need to add a token secret here. I asked back in time to PyPI to get an organization, but I need to check what happen to that request. In the meanwhile I guess we need to add a personal token. @Nicogene @mfussi66 if you want I can handle that, let me know if that is ok.

No problem!

traversaro commented 1 year ago

I added the tokens, the PR is ready for review. @Nicogene @CarlottaSartore @mfussi66 please give me your pypi handles to be added to the project, thanks!

Nicogene commented 1 year ago

I added the tokens, the PR is ready for review. @Nicogene @CarlottaSartore @mfussi66 please give me your pypi handles to be added to the project, thanks!

Mine is Nicogene

traversaro commented 1 year ago

Nicogene

Ok, I will add you as soon as the first release exists, otherwise before there is no pypi project to add you to.

mfussi66 commented 1 year ago

I added the tokens, the PR is ready for review. @Nicogene @CarlottaSartore @mfussi66 please give me your pypi handles to be added to the project, thanks!

Mine is mfuzz.

CarlottaSartore commented 1 year ago

I added the tokens, the PR is ready for review. @Nicogene @CarlottaSartore @mfussi66 please give me your pypi handles to be added to the project, thanks!

Mine is CarlottaSartore

traversaro commented 1 year ago

Thanks @Nicogene ! Can we publish a new release to check if the PyPI upload is working fine?

Nicogene commented 1 year ago

Done here:

Nicogene commented 1 year ago

Unfortunately it failed (cc @traversaro @CarlottaSartore)