search

icub-tech-iit / urdf-modifiers

BSD 3-Clause "New" or "Revised" License
14 stars 4 forks source link

Default installation instruction installs an iDynTree without irrlicht/visualizer support, but examples use irrlicht/visualizer #5

Closed traversaro closed 1 year ago

traversaro commented 2 years ago

The default installation procedure in the README will install idyntree from PyPI, but that version does not have irrlicht/visualizer support enabled (see https://github.com/robotology/robotology-superbuild/issues/1012#issuecomment-1028838376).

However, I noticed that the example https://github.com/icub-tech-iit/urdf-modifiers/blob/23d5517413e1ce765ab5857130f0b30f588b0430/examples/stickBotModification.ipynb uses the iDynTree.Visualizer function, so it could be confusing for users that try to run it.

Probably we can try to modify the README to reflect what developers are actually using (so-called "dog-fooding"), that I guess is either:

@Nicogene @GrmanRodriguez @CarlottaSartore

traversaro commented 1 year ago

I guess this was fixed by https://github.com/robotology/idyntree/pull/1045 .