search

icub-tech-iit / ventilator-FI5

FI5: Rapidly Manufactured Ventilator System
BSD 3-Clause "New" or "Revised" License
31 stars 4 forks source link

Error in BIVAR CODE for yellow and green panel LEDs in partlist #64

Closed claudiolorini closed 4 years ago

claudiolorini commented 4 years ago

Partlist

image

pattacini commented 4 years ago

@claudiolorini just a brief note: now that the repo's been made public we should no longer post links to restricted resources. Thus, I've edited your OP above with a screenshot (the quickest solution that I had).

Aside from this, who should this issue be assigned to?

claudiolorini commented 4 years ago

whoever compiled the partlist, i suppose @Fabrizio69? btw after some navigation in the project (tree and branches) i wasn't able to find the position of the partlist in the git repository, a more visible handle can be advantageous...

pattacini commented 4 years ago

Given the structure of the repo, the BOM is located in the mech branch, if that is the resource you meant.

At any rate, we should devote some effort to enrich the repo with README.md files describing the resources we made openly available as we've just gone public. In this sense, yep, we kind of still lack this type of documentation.

Anyway, @Fabrizio69 would you be willing to fix this bug in the BOM? Be careful as the mech branch is revisioned under Git LFS, although Excel files are not tracked by LFS (yet).

maggia80 commented 4 years ago

I have updated the BOM:

https://github.com/icub-tech-iit/ventilator-FI5/blob/mech/Ventilator%20FI5%20BOM%20Rev0.xlsx

I didn't change the revision, because there was only the description wrong but the part numbers were correct