search

icub-tech-iit / xcub-moveit2

Collect the outcomes of our study on the use of MoveIT with our robots
BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Add CI to the repo #17

Closed Nicogene closed 9 months ago

Nicogene commented 10 months ago

We need to add the CI once the repo has been made public

martinaxgloria commented 9 months ago

We have started discussing this issue (see here and here for reference). Any opinion about the two? I think that we could use the superbuild-ros2 docker image as a starting point but it's necessary to include also moveit2 installation. Or if we want only to check if the ros2 packages are properly compiled without errors, we could rely on ros2-moveit2 docker images provided by the community.

cc @Nicogene @pattacini

Nicogene commented 9 months ago

We have started discussing this issue (see here and here for reference). Any opinion about the two? I think that we could use the superbuild-ros2 docker image as a starting point but it's necessary to include also moveit2 installation. Or if we want only to check if the ros2 packages are properly compiled without errors, we could rely on ros2-moveit2 docker images provided by the community.

cc @Nicogene @pattacini

For starting the CI should just check that the code contained in this repository compiles fine, then probably the moveit package is not necessary.

I am ok for using the superbuild-ros2 image 👍🏻

martinaxgloria commented 9 months ago

Yesterday I started the CI implementation starting from superbuild-ros2 image. Unfortunately, some ros2 packages inside this repo has moveit dependencies, so this docker image is not sufficient to check if they are all successfully built. In this sense, I could create a Dockerfile starting from superbuild-ros2 image in which I could include also the moveit packages installation

cc @pattacini @Nicogene

martinaxgloria commented 9 months ago

I opened a PR with a workflow that checks if the packages are compiled without any errors. I tried it on my fork and it works (see the PR body)

cc @Nicogene @pattacini