Closed martinaxgloria closed 9 months ago
In my opinion, this makes the repository and the folder tree cleaner and easier to compile. But if you do not agree, I could revert it.
I do not have a strong opinion on this, but all the ros2 repos I know of, even if composed by different C++/Python packages in different directories, place this package directories directly in the root, with no src
directory, see for example:
Hi @traversaro, thanks for the feedback! Actually, you're right, it's better to have the packages in the root to be aligned to what already exists. I'm going to revert it and fix the CI
I reverted the changes regarding the folder tree, fixed the CI, and added a check to force the CI to exit when almost one of the packages fails. This is why I tried to run the workflow with an error but the CI completed the jobs successfully:
This PR introduces a workflow to check whether all the ros2 packages contained inside this repo are properly compiled without any errors. It includes:
Dockerfile
that usessuperbuild-ros2
docker image as a starting point but installs other dependencies like the MoveIt2 ones;ci.yaml
which includes a github action to build the docker image and run it;Moreover, I refactored the repository to have the ros2 packages under the
src
folder. In this way, they could be compiled starting from the root, i.e.:instead of:
In my opinion, this makes the repository and the folder tree cleaner and easier to compile. But if you do not agree, I could revert it.
I tried it on my fork and this was the result: