icy / pacapt

An ArchLinux's pacman-like shell wrapper for many package managers. 56KB and run anywhere.
Other
958 stars 69 forks source link

--noconfirm for apk #150

Closed LaszloGombos closed 3 years ago

LaszloGombos commented 3 years ago

I am getting the following error.
Error: apk: Option '--noconfirm' is not supported/implemented.

Perhaps '--noconfirm' should not need to be passed on to apk

icy commented 3 years ago

Thanks @LaszloGombos for the report.

If apk doesn't have that option, we can update this function to avoid that error message: https://github.com/icy/pacapt/blob/735b2ea56cbd8a8a61f8242ae9cd23ce6b4405ae/lib/00_core.sh#L181 . I will need to confirm this. I come across this thread https://unix.stackexchange.com/a/565076, which is positive.

@cuonglm What do you think?

cuonglm commented 3 years ago

@icy I think it's safe to return "" for alpine, as it runs non-interactive by default.

icy commented 3 years ago

@LaszloGombos @cuonglm I've raised new PR (https://github.com/icy/pacapt/pull/151). Please have a quick look. I will get it merged and released in the next minor verion. Thanks