search

icy / pacapt

An ArchLinux's pacman-like shell wrapper for many package managers. 56KB and run anywhere.
Other
958 stars 69 forks source link

Void Linux Support #215

Closed TabulateJarl8 closed 2 years ago

TabulateJarl8 commented 2 years ago

I was bored so I added support for Void Linux. Not sure if I did anything wrong, but I'm pretty sure I've checked all of the contributing boxes and all of the tests pass. Hope this is helpful!

icy commented 2 years ago

I was bored so I added support for Void Linux. Not sure if I did anything wrong, but I'm pretty sure I've checked all of the contributing boxes and all of the tests pass. Hope this is helpful!

Hi @TabulateJarl8 ,

thanks for your contribution. The old PR has some conflicts and your new one is cleaner. I will have a look today and add some tests so that it can be merged quickly.

Best,

icy commented 2 years ago

Hi @TabulateJarl8 ,

I don't think you've enabled GithubActions on your forked repository so I need to check out and run some tests locally. Congratulaions: It's all fine now! I've merged the PR and will include them in the next release very soon.

Thanks again for your contribution.

TabulateJarl8 commented 2 years ago

Sorry for the inconvenience, and you're very welcome for the contribution!

TabulateJarl8 commented 2 years ago

One thing I did notice, I seem to have forgotten to add it to the README, unless that's automatically generated, and also there's still some issues for void support open. Just figured I'd give you a heads up.

icy commented 2 years ago

Sorry for the inconvenience, and you're very welcome for the contribution!

No worries, it's also very easy to run tests locally and I often do that ;)

One thing I did notice, I seem to have forgotten to add it to the README, unless that's automatically generated, and also there's still some issues for void support open. Just figured I'd give you a heads up.

The table of all operations is updated with make update_stats ( and I did, they're on the ng branch now). I can help to update (mention) the support in the new release, no worries. You then can focus on the fix ;)