Improve the code inside solvestats module - Githubissues

icyflame / cli-cube-timer

Time your solves, without leaving the terminal

https://npmjs.org/package/cli-cube-timer

20 stars 5 forks source link

Improve the code inside solvestats module #36

Closed Jan-Ka closed 7 years ago

Jan-Ka commented 7 years ago

This resolves #30 .

3709c3fea9b7d8652412600940a7b63ba5600c01 adds a missing .gitignore
a500afcf241922d03b33061f3b455a385a18eb81 is the actual fix
ddc3b44810ae9c15d2f4cd317cdfecfa1fa17110 adds mocha as unit test framework
95389164de95fff0312a8dd72140007185c84615, d8e700058a4c832e9861b819dbc7b24afe203e38 & b0194129b7e4f25905880f37a8c7b68ee6968402 add unit tests to prove the functionality of the changes
- they were run against the unchanged code and my refactoring

One caveat: This was not tested with the rest of the application.

Jan-Ka commented 7 years ago

Major derp on my end - forgot to put changes in branch