search

icyflame / cli-cube-timer

Time your solves, without leaving the terminal
https://npmjs.org/package/cli-cube-timer
20 stars 5 forks source link

Housekeeping #40

Closed Jan-Ka closed 7 years ago

Jan-Ka commented 7 years ago

Some items interesting for general project housekeeping

Jan-Ka commented 7 years ago

If I read the Jarvis Log correctly it actually complains that there are no tests the test command can execute.

icyflame commented 7 years ago

Hey @Jan-Ka, thanks a lot for this PR. I have been meaning to do .editorconfig for a while now. Thanks :smile:

Thanks for adding a .gitignore. I have those things added to my ~/.gitignore_global, so I never see those folders anyway. I guess a lot of people don't, and it must be hell for them.

icyflame commented 7 years ago

I have seen your other PRs and it seems like you are adding unit tests. So, let's change this to exit 0 for now. And when I merge #41, I will put a mocha in the package.json.

icyflame commented 7 years ago

I have merged it in with exit 0. Will re-introduce mocha once we have the first test file added. :smile: