search

icyflame / cli-cube-timer

Time your solves, without leaving the terminal
https://npmjs.org/package/cli-cube-timer
20 stars 5 forks source link

'no such file' error on first save at LOCAL_FILE_PATH #41

Closed Jan-Ka closed 7 years ago

Jan-Ka commented 7 years ago

This request resolves #38, possible even #33.

This change requires the package.json to be updated to the latest versions just to be save.

icyflame commented 7 years ago

Hey, thanks for all your changes. I want to refocus this PR on just creating a new constant in the constants.js file, using fs.existsSync and mkdirp.sync everywhere and removing the file-exists dependency.

The unit test you added is fine and required. Once I merge the template, I will add a few more tests.

Jan-Ka commented 7 years ago

@icyflame I just pushed the changes we have discussed. I hope you find everything in order now.

icyflame commented 7 years ago

Indeed, everything is in order now. I have merged it into master. I am going to let it be there till maybe tomorrow before freezing everything. Doing a thorough test and then publishing a new version to NPM! Thanks a lot for the time you spent working on this :smile:

Jan-Ka commented 7 years ago

Glad I was able to help, I enjoyed it very much and can hopefully provide more help in the future.