icykoneko / ff14-fish-tracker-app

FF14 Fish Tracker App
https://ff14fish.carbuncleplushy.com
MIT License
61 stars 21 forks source link

Update fishing spot link to Teamcraft #103

Closed mattantonelli closed 2 years ago

mattantonelli commented 2 years ago

This change updates the fishing spot link to point to Teamcraft, which provides a lot of useful information over Garland Tools.

https://ffxivteamcraft.com/db/en/fishing-spot/216 vs https://garlandtools.org/db/#fishing/216

I ran into permissions issues when initializing the repo, so I wasn't able to test this personally, but I hope it's a small enough change that you don't mind giving it a look.

icykoneko commented 2 years ago

I don't know why folks keep getting errors cloning the repo. You did remember to include the --recurse-submodules flag, yes?

If not, you can still check them out by running git submodules update --recursive --init

mattantonelli commented 2 years ago

Yeah I copied the clone command straight from the README:

$ git clone --recurse-submodules git@github.com:icykoneko/ff14-fish-tracker-app.git
Cloning into 'ff14-fish-tracker-app'...
...
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Also tried git clone --recurse-submodules https://github.com/icykoneko/ff14-fish-tracker-app.git with a similar error.

Running the submodule update command also yields the same error.