icykoneko / ff14-fish-tracker-app

FF14 Fish Tracker App
https://ff14fish.carbuncleplushy.com
MIT License
63 stars 22 forks source link

Update fish names (manually) per Korean 5.55 patch #112

Closed hibiyasleep closed 2 years ago

hibiyasleep commented 2 years ago

Couldn't figure out how to use update tool (especially for single language) so updated fish names manually, per how korean service translated it.

what's updated (click to open) ```json "028497": "리스트라칸투스", "028038": "잠수인형", "029622": "깜짝알", "028495": "일라드 스칸", "028499": "롱카의 큰물뱀?", "028033": "수분어", "028491": "바다일등성", "028494": "비단뱀원반", "028037": "강철 면도날고기", "028036": "그림자문어", "029623": "나바스 톱", "028493": "다므뢴 버찌송어", "028498": "정천안", "028496": "깊은어둠고기", "028492": "황금 피피라", "028035": "모라 텍타", "028034": "마루 가재", ```
icykoneko commented 2 years ago

Thanks for letting me know about the updated Korean data. Sorry if the process is a bit confusing. I've taken your suggestion of generating the JSON in unicode (UTF-8) rather than the default which was Windows ASCII encoding. The data.js file is always auto-generated, so I've fixed that in the manageFishData.py script.

Usually, I'll just handle these updates. I think you may have had problems because the DAT reader is designed for the EN/JP/DE/FR version to be installed locally. It uses the repo you mentioned to obtain KO data. So, I'd assume the KO client doesn't contain the other four languages.

hibiyasleep commented 2 years ago

I didn't except you have a way to adopt .csvs over SaintCoinach integration, so have been curious how existing data were built. if there's an update after this, I'll just notify here by creating issues. thank you very much!

and yes, K client doesn't include J/E/D/F locale. accessing them will make SaintCoinach throw an exception as like there's no file exists.