search

icykoneko / ff14-fish-tracker-app

FF14 Fish Tracker App
https://ff14fish.carbuncleplushy.com
MIT License
61 stars 21 forks source link

When doing temporary manual overrides, also update DATA.FISH #143

Closed okuRaku closed 1 year ago

okuRaku commented 1 year ago

The purpose of this is to enable a code-free path to updating the Fisher's Intuition bot with manual overrides entered via CarbyUtils.setFishConditions()

icykoneko commented 1 year ago

For the benefit of github, I would not like to merge this due to the DATA object being meant to remain constant. The only consumer of this change is your discord bot, and it's technically not a direct consumer since you planned to manually use the console to dump DATA anyways. Whereas, this function's intended purpose is to provide power users with a means of changing or setting conditions without having to worry about the details of fishWatcher and weatherService.

I'd also like to point out that, while I don't have a problem with you using the contents of DATA, you should understand this format is intended to be internal to this application and is subject to change at any time without prior notice.

If you want to have this code, I would recommend instead running your fork locally and using that version.

okuRaku commented 1 year ago

The intention of this PR was to enable those same power users to provide the same data to the discord bot. It was not intended for use by me, or anyone capable of running a fork locally. Obviously they would have the knowledge to provide the same data to the bot without doing those things.

If you decide to break the bot by changing the format of DATA that would be even more disappointing yes. I hope you don't decide to do that. We should work together, not against.