search

icykoneko / ff14-fish-tracker-app

FF14 Fish Tracker App
https://ff14fish.carbuncleplushy.com
MIT License
61 stars 21 forks source link

Fish windows not ending on X:00 show as available until the hour is up #149

Closed emerald000 closed 1 year ago

emerald000 commented 1 year ago

Bug

As you can see, the window should have ended at 3:20, but was still shown as available after it. The time to window close was also counting up. The window correctly "closed" at 4:00.

DuvoisinNicolas commented 1 year ago

Happened to me too, multiple times

icykoneko commented 1 year ago

Definitely is a bug. The "Availability" column is controlled by the "countdown" timer events which occur every second; however, it assumes none of the fish have any expired "catchableRange" entries left. The pruning of expired ranges only happens on each bell (Eorzean hour), thus the display glitch.

Fixing this shouldn't be too difficult, but I'm pretty sure I designed it this way for efficiency, so I'm going to try and rework the events for tracking when a fish's window closes. For now, it doesn't appear there's any issues with off-hour opening times at least...