search

icykoneko / ff14-fish-tracker-app

FF14 Fish Tracker App
https://ff14fish.carbuncleplushy.com
MIT License
63 stars 22 forks source link

Small translation issue #40

Closed Akurosia closed 5 years ago

Akurosia commented 5 years ago

The fish "The Assassin" is translated weirdly in the German language (and might affect other fish as well). The translated name is "Meu-chel-mör-de-rin" which should just "Meu­chel­mör­de­rin".

Might be related to a beloved issue i have with community projects: "" These appear afaik only in german end french but for most projects can just be removed at completly

icykoneko commented 5 years ago

It should be using whatever the game client text uses for the German language. I don't translate anything. I'll check the string parser again. I've had issues with hyphens before.

icykoneko commented 5 years ago

There's a TagType.SoftHyphen in the string parser. While it's not part of the base Saintcoinach code, maybe that's what's causing it? Are those hyphens just in the places you'd break up the word?

icykoneko commented 5 years ago

Ok - so just spent a couple minutes researching "soft hyphens" and holy crap... I'm going to try using the ­ approach first. Technically, I have the fish names, and place names styled to nobreak anyways, so if the hyphens don't vanish, I'll just remove them I guess.