search

icykoneko / ff14-fish-tracker-app

FF14 Fish Tracker App
https://ff14fish.carbuncleplushy.com
MIT License
63 stars 22 forks source link

Support upcoming changes to Fish Eyes #65

Closed icykoneko closed 3 years ago

icykoneko commented 3 years ago

Latest Live Letter revealed Fish Eyes is going away! Well... not entirely. Fish will no longer require Fish Eyes to catch, but the buff is expected to be reworked such that it may remove time restrictions for fish. There's no indication this would work on all fish, or for how long.

How's this affect the tracker? For one, the fish eyes buff should be removed. The harder part is providing a way for users to toggle between omitting time restrictions or not (maybe add a fish eyes button).

icykoneko commented 3 years ago

This is not a trivial change. The FishWatcher service is designed specifically to only add new windows at the end. Initially, it would have computed the windows with time factored in, meaning it likely skipped windows which would exist if time wasn't a factor. In order to display this, the service would have to recompute all upcoming windows.

So, it's a bit costly. Keeping a list of both might work, but trying to combine both would create odd problems. Part of the service's compute function deals with merging windows together, so it's not really designed to manage two sets of windows at the same time. Basically, the feature is totally doable, and needs to be done, but I don't think there's going to be an optimal path soon.

icykoneko commented 3 years ago

In the last Live Letter, the Fish Eyes change slide has: オオヌシとオーシャンフィッシング That first word, オオヌシ, while written in katakana, can also be interpreted as 大主 which means Lord. This phrase shows up in the item text for most all "Big Fish", but not necessarily every one of them.

I expect the 5.4 patch data to definitely include a flag for this, but if it doesn't, using the JA dat item description should provide the answers.