search

icykoneko / ff14-fish-tracker-app

FF14 Fish Tracker App
https://ff14fish.carbuncleplushy.com
MIT License
61 stars 21 forks source link

Fish availability truncated when fish opens and closes during the same 8-hour window, across midnight. #88

Closed icykoneko closed 3 years ago

icykoneko commented 3 years ago

Reproduced with CarbyUtils:

CarbyUtils.setFishConditions("Blue Crab", {"startHour":20, "endHour":19})

The fish will only be considered up from 0-19, not 20-24 plus 0-19... That even includes if you were to reload at 21, it would be considered down still.

Bug appears to be in Fish::availableRangeDuring, which was already known to have issues.

icykoneko commented 3 years ago

Looks like it's also failing to indicate range spans periods as well...

Try: CarbyUtils.setFishConditions("Blue Crab", {"startHour":12, "endHour":20}).

icykoneko commented 3 years ago

Fixed with disjoint-ranges branch.