search

icykoneko / ff14-fish-tracker-app

FF14 Fish Tracker App
https://ff14fish.carbuncleplushy.com
MIT License
61 stars 21 forks source link

Fix for Legendary fish detection for fish eyes feature #93

Closed nukes327 closed 3 years ago

nukes327 commented 3 years ago

Legendary fish detection currently looks for the string のオオヌシ which misses a few fish that would otherwise work with Fish Eyes, notably Helicoprion and Endoceras which have オオヌシの in their description instead. Checking for just オオヌシ will fix this and should not catch other fish, as the string is only used in legendary fish.

icykoneko commented 3 years ago

Thank you for the catch! Before I merge this, would you mind fixing it in dump_new_fish_data.py as well. While it’s not yet in use, I hope to switch to this code in the future and am keeping it in sync on this sort of thing. Thanks again.

https://github.com/icykoneko/ff14-fish-tracker-app/blob/93a01f66a673efdaea5b80f692a61c1a9e07d17a/private/dump_new_fish_data.py#L516