icyleaf / halite

💎HTTP Requests Client with a chainable REST API, built-in sessions and middlewares.
MIT License
170 stars 13 forks source link

TLS\SSL #5

Closed bararchy closed 7 years ago

bararchy commented 7 years ago

Is there a way to pass in a context to use for SSL connection ? I looked at Halite::Options but didn't find it.

icyleaf commented 7 years ago

This is next step, completed basic request verbs first. Thanks for asking.

bararchy commented 7 years ago

@icyleaf Sure, I'll watch for it, when it's ready I'll start using your client :) Thanks for all the good work

icyleaf commented 7 years ago

The code is not under the tests, because i have no idea how to test, and i found nothing in crystal specs about tls/ssl, but you can try it. This implement based on Crystal's built-in HTTP::Client.new(uri : URI, tls = nil) method.

bararchy commented 7 years ago

@icyleaf Thanks for adding it, I'll test it today :)

bararchy commented 7 years ago

Working on Crystal 0.23.1, Halite: HEAD.
Can be closed.