icyleaf / markd

Yet another markdown parser, Compliant to CommonMark specification, written in Crystal.
MIT License
109 stars 30 forks source link

Unable to compile on Crystal 0.31.0 #21

Closed Hentioe closed 4 years ago

Hentioe commented 4 years ago

Changing / to // can solve some errors, and adding a return type to the overridden method can eliminate some warnings.

However, Channel was refactored and the Channel::Buffered(T)#full? method was removed. I don't know how to modify it, so I didn't open a PR.

icyleaf commented 4 years ago

@Hentioe i fix it but i did not found what you figure issue, would you explain it please?

Hentioe commented 4 years ago

Has been fixed.