search

icyleaf / markd

Yet another markdown parser, Compliant to CommonMark specification, written in Crystal.
MIT License
109 stars 30 forks source link

Reason why Markd::Options is a struct ? #39

Closed Nephos closed 2 years ago

Nephos commented 2 years ago

Hello,

I'm working on a home-made patch, using Markd as a code base.

I'm making my own classes inheriting from Markd to be able to get most of the next update without too much effort (If you have a better idea I'd like to know :D) so I can add my custom behavior over the default markdown. I want it mostly to add internal links, tagging, and minor CSS features I will add in the futur.

But I have this thing with Options wich is a structure... so A struct cannot inherit from a non-abstract struct. Which means I must fork manually to change it to a class. Any reason you put it this way ? Want to change maybe ? ;) ;)

Evening !

icyleaf commented 2 years ago

It was changed to Class (#36) but not release yet, use master branch to apply it for emergency

icyleaf commented 2 years ago

UPDATE: shards update to upgrade markd version to 0.4.1

Nephos commented 2 years ago

<3 Great thanks!