icyleaf / markd

Yet another markdown parser, Compliant to CommonMark specification, written in Crystal.
MIT License
109 stars 30 forks source link

crystal 1.2: update URI.encode (depreciation) #42

Closed Nephos closed 2 years ago

Nephos commented 2 years ago

here you go

Nephos commented 2 years ago

Of course this #encode function does not exist previous 1.2 so we should either drop support for 1.0 and 1.1 or drop the --error-on-warning flag. Do you know which version will drop support for #encode? I do not find any documentation about that.

I say that removing the flag is the better way

straight-shoota commented 2 years ago

URL.encode will be supported until Crystal 2.0