A new release with latest poncho?

icyleaf / totem

Crystal configuration with spirit. Load and parse configuration in JSON, YAML, dotenv formats.

MIT License

68 stars 5 forks source link

A new release with latest poncho? #28

Open jhf opened 1 day ago

jhf commented 1 day ago

There is a bug fix in Poncho for handling env variables that are empty. Maybe you could make a new release of Poncho, with that fix, and then use that release in Totem?

icyleaf commented 1 day ago

There is no bug fixes in https://github.com/icyleaf/poncho/pull/11 but unit test only. Is any missing of main source code to commit?

jhf commented 1 day ago

It was fixed in https://github.com/icyleaf/poncho/pull/9 but there was no test for it, and that fix was never released. I forked to fix the issue, but found, after making the test, that it was already fixed in master, but not yet released. So I added a test for that master fix.

icyleaf commented 1 day ago

popcorn v0.4.1 was out, you can use execute shards update popcorn to upgrade dependency.