search

icyphox / legit

web frontend for git
https://git.icyphox.sh
MIT License
376 stars 25 forks source link

Category support #17

Closed daenney closed 1 year ago

daenney commented 1 year ago

Please excuse the code, it's a bit of a mess right now. I'm raising this so we have something to talk about with regards to how to implement category support. This change does not include updates to the "index" template just yet, I'll deal with that once we're happy with the general shape of things. All the other templates should still be working without modification.

daenney commented 1 year ago

Added a quick template change so it at least enumerates children which makes everything else easier to reach/navigate.

icyphox commented 1 year ago

Hi there,

Thank you for your work, this looks pretty great already! Just a heads up: I won't be available for the next 15 odd days as I'm in the middle of a big move, so probably don't expect any activity from my side until then. Sorry!

daenney commented 1 year ago

Hi there, Thank you for your work, this looks pretty great already! Just a heads up: I won't be available for the next 15 odd days as I'm in the middle of a big move, so probably don't expect any activity from my side until then. Sorry!

Good luck with the move! I'll keep tinkering away at this for a bit so hopefully by the time you're all done there should be something ready for review. Though what I have currently works I want to spend some time cleaning this up first.

daenney commented 1 year ago

I think this is in decent shape now, though my HTML and CSS skills are sub-zero. If there's a better way to do this I'm happy to make the changes.

The entries thing with children and repos works in practice, though it feels more convoluted than I'd like. I have the feeling there's a simpler way to achieve this but my brain isn't seeing it.

icyphox commented 1 year ago

Hi @daenney, this patch has come out rather nicely. I’ll need a few more days to settle down and I’ll give this branch a spin to test everything out. We’ll merge it after. And apologies for the delay!

daenney commented 1 year ago

Hi @daenney, this patch has come out rather nicely. I’ll need a few more days to settle down and I’ll give this branch a spin to test everything out. We’ll merge it after. And apologies for the delay!

Hiya! Glad to hear you're getting settled and might have some time to look at it soon. Don't worry about the delay, there's absolutely no rush or urgency behind this!

icyphox commented 1 year ago

Hey @daenney, finally got some time to test this out -- it's great! I might make some stylistic tweaks but the meat of it works perfectly. Thanks again for this change!

icyphox commented 1 year ago

Hi again, so looks like this patch -- as it stands -- appears to break clones. Something I didn't test being in the hurry that I was (my bad!). So for now, I've dropped the commit from master. I'll figure out why it breaks, fix it, and add it back.

daenney commented 1 year ago

Oh, that's odd. I could've sworn I tested that, but I might've only been push-pulling over SSH. Sorry about that.

icyphox commented 1 year ago

Hey, I haven't forgotten about this. I just haven't found the time to work on legit -- rest assured, I'll get back to it soon(tm).