search

icytornado / pe

0 stars 0 forks source link

edit command field syntax error #3

Open icytornado opened 3 years ago

icytornado commented 3 years ago

steps to reproduce:

add -n Ben Doe -p 98775432 -e johnd@example.com -c Google -j Software Engineer -a 311, Clementi Ave 2, *02-25 -r University friend -t friends -t owesMoney

expected: warning saying address 311, Clementi Ave 2, *02-25 not allowed, because wrong syntax

acutal: the address is allowed to be added in.

Screenshot 2021-04-16 at 2.39.06 PM.png

nus-pe-bot commented 3 years ago

Team's Response

The mentioned behaviour is expected. The address in your example is allowed. It is mentioned in our UG that address has no restrictions on syntax or length. Only that it cannot be blank.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I disagree, because this is clearly an issue.

Moreover, the dev team's response is also invalid. "Address can take any values, and it should not be blank" does not mean it can take in an invalid address.

Furthermore, if such invalid address is allowed to be added into the list, there will be great inconvenient for the users when they are trying to find someone or mail someone from the list.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: If such invalid address is allowed to be added into the list, there will be great inconvenient for the users when they are trying to find someone or mail someone from the list.

In fact, now i think the severity level should be medium instead.